Support quickfix for gradle jpms projects #2304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
CsCherrYY
force-pushed
the
cs-gradle-jpms
branch
from
5761d47
to
6272c08
Compare
|
@rgrunber @testforstephen @jdneo I have addressed the conflicts and updated the descriptions. feel free to review and comment :) |
CsCherrYY
force-pushed
the
cs-gradle-jpms
branch
from
6272c08
to
14e131e
Compare
jdneo
reviewed
Nov 30, 2022
...src/org/eclipse/jdt/ls/core/internal/corrections/proposals/GradleCompatibilityProcessor.java
Show resolved
Hide resolved
jdneo
reviewed
Nov 30, 2022
...src/org/eclipse/jdt/ls/core/internal/corrections/proposals/GradleCompatibilityProcessor.java
Show resolved
Hide resolved
...eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/GradleProjectImporter.java
Outdated
Show resolved
Hide resolved
jdneo
reviewed
Dec 20, 2022
| try { | ||
| ClasspathResult result = ProjectCommand.getClasspathsFromJavaProject(javaProject, new ProjectCommand.ClasspathOptions()); | ||
| IModuleDescription moduleDescription = javaProject.getModuleDescription(); | ||
| if (moduleDescription == null) { |
There was a problem hiding this comment.
Suggest extracting the code in if-else blocks to methods separately - for better readiness.
Signed-off-by: Shi Chen <chenshi@microsoft.com>
Signed-off-by: Shi Chen <chenshi@microsoft.com>
CsCherrYY
force-pushed
the
cs-gradle-jpms
branch
from
80188ac
to
daf2a76
Compare
|
Since this issue related to the Gradle versions under Gradle 7, which do not support the current test environment (Java 17), so the test cases can't be added until we support running tests in another Java version. |
Signed-off-by: Shi Chen <chenshi@microsoft.com>
jdneo
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shi Chen chenshi@microsoft.com
related to redhat-developer/vscode-java#2773
Gradle provides better JPMS support since 7.0, see: gradle/gradle#890 (comment), which means the Gradle versions under 7.0 might cause some issues, and the user will see errors such as "xxx is not accessible".
See gradle/gradle#16922, Gradle 7.0.1 added an extra fix about JPMS projects, so 7.0.1 is a better recommendation version IMO.
this PR provides a quickfix to help users upgrade the gradle version.
action.mp4